fix: panic on embedded struct with recursive #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NgoKimPhu
force-pushed
the
fix/recurse-anonymous-panic
branch
from
2cfcb0c to
078b728
Compare
NgoKimPhu
force-pushed
the
fix/recurse-anonymous-panic
branch
from
078b728 to
b7136cc
Compare
|
ready to merge, I meet same issue |
|
I've seen the same issue @goccy and can confirm that the PR did fix the issue for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #459 (panic on embedded struct with recursive) and #468 which is caused by a missing population of anonymous struct fields into
encoder.compileContext.structTypeToCodesin the logic ofencoder.StructCode.ToAnonymousOpcode.